gst/h264parse/gsth264parse.c: Fix potential buffer leak in reverse mode. Re-Fixes...

Original commit message from CVS:
Patch by: Josep Torra Valles <josep@fluendo.com>
* gst/h264parse/gsth264parse.c: (gst_h264_parse_chain_reverse):
Fix potential buffer leak in reverse mode. Re-Fixes #516061.

diff --git a/ChangeLog b/ChangeLog
index a95e06d..9460004 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-02-13  Wim Taymans  <wim.taymans@collabora.co.uk>
+
+       Patch by: Josep Torra Valles <josep@fluendo.com>
+
+       * gst/h264parse/gsth264parse.c: (gst_h264_parse_chain_reverse):
+       Fix potential buffer leak in reverse mode. Re-Fixes #516061.
+
 2008-02-13  Sebastian Dröge  <slomo@circular-chaos.org>
 
        * configure.ac:

diff --git a/gst/h264parse/gsth264parse.c b/gst/h264parse/gsth264parse.c
index 12b2ba7..45d6337 100644 (file)
--- a/gst/h264parse/gsth264parse.c
+++ b/gst/h264parse/gsth264parse.c
@@ -704,6 +704,8 @@ gst_h264_parse_chain_reverse (GstH264Parse * h264parse, gboolean discont,
       guint8 *data;
 
       /* get new buffer and init the start code search to the end position */
+      if (gbuf != NULL)
+        gst_buffer_unref (gbuf);
       gbuf = GST_BUFFER_CAST (h264parse->gather->data);
 
       /* remove from the gather list, they are in reverse order */