logging: more logging and prefer human readable details over memory locations

diff --git a/gst/gstbin.c b/gst/gstbin.c
index bfaba56..bdf01a7 100644 (file)
--- a/gst/gstbin.c
+++ b/gst/gstbin.c
@@ -2701,6 +2701,8 @@ gst_bin_send_event (GstElement * element, GstEvent * event)
         gst_event_ref (event);
         child = GST_ELEMENT_CAST (data);
         res &= gst_element_send_event (child, event);
+        GST_LOG_OBJECT (child, "After handling %s event: %d",
+            GST_EVENT_TYPE_NAME (event), res);
         gst_object_unref (child);
         break;
       }

diff --git a/gst/gstbus.c b/gst/gstbus.c
index 9e462e4..0ef5b98 100644 (file)
--- a/gst/gstbus.c
+++ b/gst/gstbus.c
@@ -494,8 +494,9 @@ gst_bus_timed_pop_filtered (GstBus * bus, GstClockTime timeout,
     GST_LOG_OBJECT (bus, "have %d messages", g_queue_get_length (bus->queue));
 
     while ((message = g_queue_pop_head (bus->queue))) {
-      GST_DEBUG_OBJECT (bus, "got message %p, %s, type mask is %u",
-          message, GST_MESSAGE_TYPE_NAME (message), (guint) types);
+      GST_DEBUG_OBJECT (bus, "got message %p, %s from %s, type mask is %u",
+          message, GST_MESSAGE_TYPE_NAME (message),
+          GST_OBJECT_NAME (GST_MESSAGE_SRC (message)), (guint) types);
       if ((GST_MESSAGE_TYPE (message) & types) != 0) {
         /* exit the loop, we have a message */
         goto beach;
@@ -756,7 +757,8 @@ gst_bus_source_dispatch (GSource * source, GSourceFunc callback,
   if (!handler)
     goto no_handler;
 
-  GST_DEBUG_OBJECT (bus, "source %p calling dispatch with %p", source, message);
+  GST_DEBUG_OBJECT (bus, "source %p calling dispatch with %" GST_PTR_FORMAT,
+      source, message);
 
   keep = handler (bus, message, user_data);
   gst_message_unref (message);

diff --git a/gst/gstmessage.c b/gst/gstmessage.c
index ac33800..93b34fd 100644 (file)
--- a/gst/gstmessage.c
+++ b/gst/gstmessage.c
@@ -191,7 +191,9 @@ gst_message_finalize (GstMessage * message)
 {
   g_return_if_fail (message != NULL);
 
-  GST_CAT_LOG (GST_CAT_MESSAGE, "finalize message %p", message);
+  GST_CAT_LOG (GST_CAT_MESSAGE, "finalize message %p, %s from %s", message,
+      GST_MESSAGE_TYPE_NAME (message),
+      GST_OBJECT_NAME (GST_MESSAGE_SRC (message)));
 
   if (GST_MESSAGE_SRC (message)) {
     gst_object_unref (GST_MESSAGE_SRC (message));
@@ -217,7 +219,9 @@ _gst_message_copy (GstMessage * message)
 {
   GstMessage *copy;
 
-  GST_CAT_LOG (GST_CAT_MESSAGE, "copy message %p", message);
+  GST_CAT_LOG (GST_CAT_MESSAGE, "copy message %p, %s from %s", message,
+      GST_MESSAGE_TYPE_NAME (message),
+      GST_OBJECT_NAME (GST_MESSAGE_SRC (message)));
 
   copy = (GstMessage *) gst_mini_object_new (GST_TYPE_MESSAGE);
 

diff --git a/libs/gst/base/gstbasesink.c b/libs/gst/base/gstbasesink.c
index c712101..1e63b28 100644 (file)
--- a/libs/gst/base/gstbasesink.c
+++ b/libs/gst/base/gstbasesink.c
@@ -2196,8 +2196,8 @@ gst_base_sink_wait_clock (GstBaseSink * sink, GstClockTime time,
   /* FIXME: Casting to GstClockEntry only works because the types
    * are the same */
   if (G_LIKELY (sink->priv->cached_clock_id != NULL
-          && GST_CLOCK_ENTRY_CLOCK ((GstClockEntry *) sink->
-              priv->cached_clock_id) == clock)) {
+          && GST_CLOCK_ENTRY_CLOCK ((GstClockEntry *) sink->priv->
+              cached_clock_id) == clock)) {
     if (!gst_clock_single_shot_id_reinit (clock, sink->priv->cached_clock_id,
             time)) {
       gst_clock_id_unref (sink->priv->cached_clock_id);
@@ -4535,6 +4535,10 @@ gst_base_sink_send_event (GstElement * element, GstEvent * event)
   }
 
   gst_object_unref (pad);
+
+  GST_DEBUG_OBJECT (basesink, "handled event %p %" GST_PTR_FORMAT ": %d", event,
+      event, result);
+
   return result;
 }