btrfs: include error on messages about failure to write space/inode caches
authorFilipe Manana <fdmanana@suse.com>
Mon, 18 May 2020 16:34:11 +0000 (17:34 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 25 May 2020 09:25:38 +0000 (11:25 +0200)
Currently the error messages logged when we fail to write a free space
cache or an inode cache are not very useful as they don't mention what
was the error. So include the error number in the messages.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/free-space-cache.c

index 525bc5a..01e8451 100644 (file)
@@ -1193,8 +1193,8 @@ out:
                if (block_group) {
 #ifdef CONFIG_BTRFS_DEBUG
                        btrfs_err(root->fs_info,
-                                 "failed to write free space cache for block group %llu",
-                                 block_group->start);
+         "failed to write free space cache for block group %llu error %d",
+                                 block_group->start, ret);
 #endif
                }
        }
@@ -1417,8 +1417,8 @@ int btrfs_write_out_cache(struct btrfs_trans_handle *trans,
        if (ret) {
 #ifdef CONFIG_BTRFS_DEBUG
                btrfs_err(fs_info,
-                         "failed to write free space cache for block group %llu",
-                         block_group->start);
+         "failed to write free space cache for block group %llu error %d",
+                         block_group->start, ret);
 #endif
                spin_lock(&block_group->lock);
                block_group->disk_cache_state = BTRFS_DC_ERROR;
@@ -3997,8 +3997,8 @@ int btrfs_write_out_ino_cache(struct btrfs_root *root,
                                        inode->i_size, true);
 #ifdef CONFIG_BTRFS_DEBUG
                btrfs_err(fs_info,
-                         "failed to write free ino cache for root %llu",
-                         root->root_key.objectid);
+                         "failed to write free ino cache for root %llu error %d",
+                         root->root_key.objectid, ret);
 #endif
        }