virtio-rng: fix check for period_ms validity
authorJinhyung Jo <jinhyung.jo@samsung.com>
Thu, 1 Jun 2017 11:36:36 +0000 (20:36 +0900)
committerJinhyung Jo <jinhyung.jo@samsung.com>
Wed, 7 Jun 2017 11:33:19 +0000 (20:33 +0900)
This was reported for this warning:

hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to
the left hand side of comparison [-Wlogical-not-parentheses]

Change-Id: I7912c36bfd7520de2b9bfb14c92442fdea68d062
Signed-off-by: Jinhyung Jo <jinhyung.jo@samsung.com>
(cherry picked from commit adbf8ffec5766d9f9c4abe92df6c4c201eb95b80)

hw/virtio/virtio-rng.c

index b6ab3610cbcec2baf96fb3d954abbcb8431091d3..d44a73a51d38e911d6ec9567c3d3193165a01cb0 100644 (file)
@@ -140,7 +140,7 @@ static void virtio_rng_device_realize(DeviceState *dev, Error **errp)
     VirtIORNG *vrng = VIRTIO_RNG(dev);
     Error *local_err = NULL;
 
-    if (!vrng->conf.period_ms > 0) {
+    if (vrng->conf.period_ms <= 0) {
         error_set(errp, QERR_INVALID_PARAMETER_VALUE, "period",
                   "a positive number");
         return;