anv: re-alloc push constants after secondary command buffers
authorIván Briano <ivan.briano@intel.com>
Tue, 10 May 2022 01:30:20 +0000 (18:30 -0700)
committerMarge Bot <emma+marge@anholt.net>
Tue, 10 May 2022 21:56:49 +0000 (21:56 +0000)
If the secondary command buffer executed used push constants on a
different set of stages than the primary is using, we may end up not
reallocating them for the primary, getting misrender artifacts at best,
or a nice GPU hang at worst.

Fixes the tests from a CTS from the future:
dEQP-VK.dynamic_rendering.random.*

Cc: mesa-stable
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16439>

src/intel/vulkan/genX_cmd_buffer.c

index 1bb7ec3..1330355 100644 (file)
@@ -1995,6 +1995,7 @@ genX(CmdExecuteCommands)(
    primary->state.current_l3_config = NULL;
    primary->state.current_hash_scale = 0;
    primary->state.gfx.dirty |= ANV_CMD_DIRTY_DYNAMIC_ALL;
+   primary->state.gfx.push_constant_stages = 0;
 
    /* Each of the secondary command buffers will use its own state base
     * address.  We need to re-emit state base address for the primary after