spi: ath79: remove spi-master setup and cleanup assignment
authorDavid Bauer <mail@david-bauer.net>
Wed, 3 Mar 2021 16:08:37 +0000 (17:08 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 May 2021 12:47:16 +0000 (14:47 +0200)
[ Upstream commit ffb597b2bd3cd78b9bfb68f536743cd46dbb2cc4 ]

This removes the assignment of setup and cleanup functions for the ath79
target. Assigning the setup-method will lead to 'setup_transfer' not
being assigned in spi_bitbang_init. Because of this, performing any
TX/RX operation will lead to a kernel oops.

Also drop the redundant cleanup assignment, as it's also assigned in
spi_bitbang_init.

Signed-off-by: David Bauer <mail@david-bauer.net>
Link: https://lore.kernel.org/r/20210303160837.165771-2-mail@david-bauer.net
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-ath79.c

index 436327f..98ace74 100644 (file)
@@ -156,8 +156,6 @@ static int ath79_spi_probe(struct platform_device *pdev)
 
        master->use_gpio_descriptors = true;
        master->bits_per_word_mask = SPI_BPW_RANGE_MASK(1, 32);
-       master->setup = spi_bitbang_setup;
-       master->cleanup = spi_bitbang_cleanup;
        master->flags = SPI_MASTER_GPIO_SS;
        if (pdata) {
                master->bus_num = pdata->bus_num;