ASoC: tas2562: remove warning on return value
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 12 Mar 2021 18:22:43 +0000 (12:22 -0600)
committerMark Brown <broonie@kernel.org>
Thu, 18 Mar 2021 13:50:52 +0000 (13:50 +0000)
cppcheck warning:

sound/soc/codecs/tas2562.c:530:9: warning: Identical condition and return expression 'ret', return value is always 0 [identicalConditionAfterEarlyExit]
 return ret;
        ^
sound/soc/codecs/tas2562.c:525:6: note: If condition 'ret' is true, the function will return/exit
 if (ret)
     ^
sound/soc/codecs/tas2562.c:530:9: note: Returning identical expression 'ret'
 return ret;
        ^

Fix with return 0

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210312182246.5153-21-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tas2562.c

index ba23f9f..1030255 100644 (file)
@@ -526,7 +526,7 @@ static int tas2562_volume_control_put(struct snd_kcontrol *kcontrol,
 
        tas2562->volume_lvl = ucontrol->value.integer.value[0];
 
-       return ret;
+       return 0;
 }
 
 /* Digital Volume Control. From 0 dB to -110 dB in 1 dB steps */