mmap: use the VMA iterator in count_vma_pages_range()
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Tue, 6 Sep 2022 19:48:46 +0000 (19:48 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 27 Sep 2022 02:46:15 +0000 (19:46 -0700)
This simplifies the implementation and is faster than using the linked
list.

Link: https://lkml.kernel.org/r/20220906194824.2110408-11-Liam.Howlett@oracle.com
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Tested-by: Yu Zhao <yuzhao@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Howells <dhowells@redhat.com>
Cc: SeongJae Park <sj@kernel.org>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/mmap.c

index 2071864..f1b0775 100644 (file)
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -629,29 +629,19 @@ munmap_vma_range(struct mm_struct *mm, unsigned long start, unsigned long len,
 
        return 0;
 }
+
 static unsigned long count_vma_pages_range(struct mm_struct *mm,
                unsigned long addr, unsigned long end)
 {
-       unsigned long nr_pages = 0;
+       VMA_ITERATOR(vmi, mm, addr);
        struct vm_area_struct *vma;
+       unsigned long nr_pages = 0;
 
-       /* Find first overlapping mapping */
-       vma = find_vma_intersection(mm, addr, end);
-       if (!vma)
-               return 0;
-
-       nr_pages = (min(end, vma->vm_end) -
-               max(addr, vma->vm_start)) >> PAGE_SHIFT;
-
-       /* Iterate over the rest of the overlaps */
-       for (vma = vma->vm_next; vma; vma = vma->vm_next) {
-               unsigned long overlap_len;
-
-               if (vma->vm_start > end)
-                       break;
+       for_each_vma_range(vmi, vma, end) {
+               unsigned long vm_start = max(addr, vma->vm_start);
+               unsigned long vm_end = min(end, vma->vm_end);
 
-               overlap_len = min(end, vma->vm_end) - vma->vm_start;
-               nr_pages += overlap_len >> PAGE_SHIFT;
+               nr_pages += PHYS_PFN(vm_end - vm_start);
        }
 
        return nr_pages;