bpf, x64: Remove unnecessary check on existence of SSE2
authorJie Meng <jmeng@fb.com>
Wed, 5 Oct 2022 17:00:39 +0000 (10:00 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 7 Oct 2022 14:22:07 +0000 (16:22 +0200)
SSE2 and hence lfence are architectural in x86-64 and no need to check
whether they're supported in CPU. SSE2's CPUID flag is still set to
maintain backward compatibility with older code or code shared with x86,
but bpf_jit_comp.c is compiled under x86-64 exclusively so the check is
redundant.

Signed-off-by: Jie Meng <jmeng@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: KP Singh <kpsingh@kernel.org>
Link: https://lore.kernel.org/bpf/20221005170039.3936894-1-jmeng@fb.com
arch/x86/net/bpf_jit_comp.c

index 9962042..0abd082 100644 (file)
@@ -1226,8 +1226,7 @@ static int do_jit(struct bpf_prog *bpf_prog, int *addrs, u8 *image, u8 *rw_image
 
                        /* speculation barrier */
                case BPF_ST | BPF_NOSPEC:
-                       if (boot_cpu_has(X86_FEATURE_XMM2))
-                               EMIT_LFENCE();
+                       EMIT_LFENCE();
                        break;
 
                        /* ST: *(u8*)(dst_reg + off) = imm */