Fix various Klocwork errors

Change-Id: I99771e74bce1d575f4d3750df3fbc43d4a1649af

diff --git a/adaptors/base/display-connection.cpp b/adaptors/base/display-connection.cpp
index e69ef62..1dc44e9 100644 (file)
--- a/adaptors/base/display-connection.cpp
+++ b/adaptors/base/display-connection.cpp
@@ -35,6 +35,7 @@ DisplayConnection* DisplayConnection::New()
 }
 
 DisplayConnection::DisplayConnection()
+: mImpl( NULL )
 {
 }
 

diff --git a/adaptors/base/environment-options.cpp b/adaptors/base/environment-options.cpp
index 64c99e3..150b9d7 100644 (file)
--- a/adaptors/base/environment-options.cpp
+++ b/adaptors/base/environment-options.cpp
@@ -104,7 +104,8 @@ EnvironmentOptions::EnvironmentOptions()
   mGlesCallTime(0),
   mWindowWidth( 0 ),
   mWindowHeight( 0 ),
-  mThreadingMode( ThreadingMode::SEPARATE_UPDATE_RENDER )
+  mThreadingMode( ThreadingMode::SEPARATE_UPDATE_RENDER ),
+  mLogFunction( NULL )
 {
   ParseEnvironmentOptions();
 }

diff --git a/adaptors/common/adaptor-impl.cpp b/adaptors/common/adaptor-impl.cpp
index 6efd3bc..3e6a1ed 100644 (file)
--- a/adaptors/common/adaptor-impl.cpp
+++ b/adaptors/common/adaptor-impl.cpp
@@ -762,12 +762,13 @@ void Adaptor::ProcessCoreEventsFromIdle()
 Adaptor::Adaptor(Any nativeWindow, Dali::Adaptor& adaptor, RenderSurface* surface, EnvironmentOptions* environmentOptions)
 : mResizedSignal(),
   mLanguageChangedSignal(),
-  mAdaptor(adaptor),
-  mState(READY),
-  mCore(NULL),
-  mThreadController(NULL),
-  mVSyncMonitor(NULL),
+  mAdaptor( adaptor ),
+  mState( READY ),
+  mCore( NULL ),
+  mThreadController( NULL ),
+  mVSyncMonitor( NULL ),
   mGLES( NULL ),
+  mGlSync( NULL ),
   mEglFactory( NULL ),
   mNativeWindow( nativeWindow ),
   mSurface( surface ),
@@ -775,14 +776,21 @@ Adaptor::Adaptor(Any nativeWindow, Dali::Adaptor& adaptor, RenderSurface* surfac
   mEventHandler( NULL ),
   mCallbackManager( NULL ),
   mNotificationOnIdleInstalled( false ),
-  mNotificationTrigger(NULL),
-  mGestureManager(NULL),
+  mNotificationTrigger( NULL ),
+  mGestureManager( NULL ),
+  mDaliFeedbackPlugin(),
+  mFeedbackController( NULL ),
+  mTtsPlayers(),
   mObservers(),
   mDragAndDropDetector(),
-  mDeferredRotationObserver(NULL),
+  mDeferredRotationObserver( NULL ),
   mEnvironmentOptions( environmentOptions ? environmentOptions : new EnvironmentOptions /* Create the options if not provided */),
-  mPerformanceInterface(NULL),
-  mObjectProfiler(NULL),
+  mPerformanceInterface( NULL ),
+  mKernelTracer(),
+  mSystemTracer(),
+  mTriggerEventFactory(),
+  mObjectProfiler( NULL ),
+  mSocketFactory(),
   mEnvironmentOptionsOwned( environmentOptions ? false : true /* If not provided then we own the object */ )
 {
   DALI_ASSERT_ALWAYS( !IsAvailable() && "Cannot create more than one Adaptor per thread" );

diff --git a/adaptors/common/networking/socket-impl.cpp b/adaptors/common/networking/socket-impl.cpp
index edb823d..05f2862 100644 (file)
--- a/adaptors/common/networking/socket-impl.cpp
+++ b/adaptors/common/networking/socket-impl.cpp
@@ -59,6 +59,10 @@ Socket::Socket( Protocol protocol , int fileDescriptor )
   if( mSocketFileDescriptor == -1)
   {
     mSocketFileDescriptor = socket( addressFamily,type, netProtocol);
+    if( mSocketFileDescriptor == -1 )
+    {
+      DALI_LOG_ERROR( "Unable to create socket" );
+    }
   }
   else
   {

diff --git a/platform-abstractions/portable/image-operations.cpp b/platform-abstractions/portable/image-operations.cpp
index 6a95969..fd2e836 100644 (file)
--- a/platform-abstractions/portable/image-operations.cpp
+++ b/platform-abstractions/portable/image-operations.cpp
@@ -299,7 +299,7 @@ ImageDimensions FitToScalingMode( ImageDimensions requestedSize, ImageDimensions
       fitDimensions = FitForFitHeight( requestedSize, sourceSize );
       break;
     }
-  };
+  }
 
   return fitDimensions;
 }