lib: pmp_set/pmp_get moved errors from runtime to compile time
authorXiang W <wxjstz@126.com>
Tue, 15 Mar 2022 16:22:38 +0000 (00:22 +0800)
committerAnup Patel <anup@brainfault.org>
Sun, 27 Mar 2022 03:22:19 +0000 (08:52 +0530)
pmp_set/pmp_get calculates the location of the CSR register separately
through conditional compilation. In the case of non-32-bit and 64-bit,
we can report an error directly through #error without putting it at
runtime

Signed-off-by: Xiang W <wxjstz@126.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
lib/sbi/riscv_asm.c

index 847bdba..5eab1ed 100644 (file)
@@ -261,7 +261,7 @@ int pmp_set(unsigned int n, unsigned long prot, unsigned long addr,
        pmpcfg_csr   = (CSR_PMPCFG0 + (n >> 2)) & ~1;
        pmpcfg_shift = (n & 7) << 3;
 #else
-       return SBI_ENOTSUPP;
+# error "Unexpected __riscv_xlen"
 #endif
        pmpaddr_csr = CSR_PMPADDR0 + n;
 
@@ -312,7 +312,7 @@ int pmp_get(unsigned int n, unsigned long *prot_out, unsigned long *addr_out,
        pmpcfg_csr   = (CSR_PMPCFG0 + (n >> 2)) & ~1;
        pmpcfg_shift = (n & 7) << 3;
 #else
-       return SBI_ENOTSUPP;
+# error "Unexpected __riscv_xlen"
 #endif
        pmpaddr_csr = CSR_PMPADDR0 + n;