ASoC: SOF: AMD: simplify return status handling
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 21 Dec 2021 16:57:57 +0000 (22:27 +0530)
committerMark Brown <broonie@kernel.org>
Tue, 21 Dec 2021 18:05:39 +0000 (18:05 +0000)
cppcheck warning:

sound/soc/sof/amd/acp.c:222:9: warning: Identical condition and return
expression 'ret', return value is always 0
[identicalConditionAfterEarlyExit]
 return ret;
        ^
sound/soc/sof/amd/acp.c:213:6: note: If condition 'ret' is true, the
function will return/exit
 if (ret)
     ^
sound/soc/sof/amd/acp.c:222:9: note: Returning identical expression 'ret'
 return ret;
        ^

Just return 0; on success.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
Link: https://lore.kernel.org/r/20211221165802.236843-1-AjitKumar.Pandey@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/amd/acp.c

index 4c5550e..fe9b7dc 100644 (file)
@@ -219,7 +219,7 @@ int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr,
                return -EINVAL;
        }
 
-       return ret;
+       return 0;
 }
 
 int acp_dma_status(struct acp_dev_data *adata, unsigned char ch)