mm: compaction: change fast_isolate_freepages() to void type
authorBaolin Wang <baolin.wang@linux.alibaba.com>
Thu, 25 May 2023 12:53:57 +0000 (20:53 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 9 Jun 2023 23:25:42 +0000 (16:25 -0700)
No caller cares about the return value of fast_isolate_freepages(), void
it.

Link: https://lkml.kernel.org/r/759fca20b22ebf4c81afa30496837b9e0fb2e53b.1685018752.git.baolin.wang@linux.alibaba.com
Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/compaction.c

index 83004c1..d4cee58 100644 (file)
@@ -1413,8 +1413,7 @@ static int next_search_order(struct compact_control *cc, int order)
        return order;
 }
 
-static unsigned long
-fast_isolate_freepages(struct compact_control *cc)
+static void fast_isolate_freepages(struct compact_control *cc)
 {
        unsigned int limit = max(1U, freelist_scan_limit(cc) >> 1);
        unsigned int nr_scanned = 0;
@@ -1427,7 +1426,7 @@ fast_isolate_freepages(struct compact_control *cc)
 
        /* Full compaction passes in a negative order */
        if (cc->order <= 0)
-               return cc->free_pfn;
+               return;
 
        /*
         * If starting the scan, use a deeper search and use the highest
@@ -1566,11 +1565,10 @@ fast_isolate_freepages(struct compact_control *cc)
 
        cc->total_free_scanned += nr_scanned;
        if (!page)
-               return cc->free_pfn;
+               return;
 
        low_pfn = page_to_pfn(page);
        fast_isolate_around(cc, low_pfn);
-       return low_pfn;
 }
 
 /*