hover: Fix hover parts usage
authorJean-Philippe Andre <jp.andre@samsung.com>
Wed, 20 Sep 2017 09:05:03 +0000 (18:05 +0900)
committerJean-Philippe Andre <jp.andre@samsung.com>
Thu, 21 Sep 2017 03:28:20 +0000 (12:28 +0900)
The string comparison was invalid for full part names. It worked with
the aliases, by chance, not by design.

This got broken by eee60abbcf but using full part names from the
application side was already broken before that.

@fix

src/lib/elementary/elm_hover.c

index 0e8f858..7d51ae7 100644 (file)
@@ -456,8 +456,8 @@ _elm_hover_content_set(Eo *obj, Elm_Hover_Data *sd, const char *swallow, Evas_Ob
    int_ret = efl_content_set(efl_part(efl_super(obj, MY_CLASS), swallow), content);
    if (!int_ret) return EINA_FALSE;
 
-   if (strstr(swallow, "elm.swallow.slot."))
-     swallow += sizeof("elm.swallow.slot.");
+   if (!strncmp(swallow, "elm.swallow.slot.", sizeof("elm.swallow.slot")))
+     swallow += sizeof("elm.swallow.slot");
 
    ELM_HOVER_PARTS_FOREACH
    {