spi: spi-mux: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Tue, 1 Sep 2020 15:27:08 +0000 (17:27 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 8 Sep 2020 17:19:27 +0000 (18:19 +0100)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200901152713.18629-6-krzk@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mux.c

index cc9ef37..37dfc6e 100644 (file)
@@ -139,9 +139,8 @@ static int spi_mux_probe(struct spi_device *spi)
 
        priv->mux = devm_mux_control_get(&spi->dev, NULL);
        if (IS_ERR(priv->mux)) {
-               ret = PTR_ERR(priv->mux);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&spi->dev, "failed to get control-mux\n");
+               ret = dev_err_probe(&spi->dev, PTR_ERR(priv->mux),
+                                   "failed to get control-mux\n");
                goto err_put_ctlr;
        }