spi: atmel: No need to call spi_master_put() if spi_alloc_master() failed
authorPeng Fan <fanpeng@loongson.cn>
Tue, 7 Jul 2020 08:50:42 +0000 (16:50 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 7 Jul 2020 13:26:31 +0000 (14:26 +0100)
There is no need to call spi_master_put() if spi_alloc_master()
failed, it should return -ENOMEM directly.

Signed-off-by: Peng Fan <fanpeng@loongson.cn>
Link: https://lore.kernel.org/r/1594111842-9468-1-git-send-email-fanpeng@loongson.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-atmel.c

index 57ee8c3..6ed7abd 100644 (file)
@@ -1546,10 +1546,9 @@ static int atmel_spi_probe(struct platform_device *pdev)
                return PTR_ERR(clk);
 
        /* setup spi core then atmel-specific driver state */
-       ret = -ENOMEM;
        master = spi_alloc_master(&pdev->dev, sizeof(*as));
        if (!master)
-               goto out_free;
+               return -ENOMEM;
 
        /* the spi->mode bits understood by this driver: */
        master->use_gpio_descriptors = true;