ASoC: SOF: ipc4: Log the tx message before sending it
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Tue, 18 Oct 2022 12:40:05 +0000 (15:40 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 18 Oct 2022 18:16:42 +0000 (19:16 +0100)
It makes more sense to log the message before it is sent to the DSP.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Link: https://lore.kernel.org/r/20221018124008.6846-2-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/ipc4.c

index 6eaa18e..3c9b869 100644 (file)
@@ -342,6 +342,8 @@ static int ipc4_tx_msg_unlocked(struct snd_sof_ipc *ipc,
        if (msg_bytes > ipc->max_payload_size || reply_bytes > ipc->max_payload_size)
                return -EINVAL;
 
+       sof_ipc4_log_header(sdev->dev, "ipc tx      ", msg_data, true);
+
        ret = sof_ipc_send_msg(sdev, msg_data, msg_bytes, reply_bytes);
        if (ret) {
                dev_err_ratelimited(sdev->dev,
@@ -350,8 +352,6 @@ static int ipc4_tx_msg_unlocked(struct snd_sof_ipc *ipc,
                return ret;
        }
 
-       sof_ipc4_log_header(sdev->dev, "ipc tx      ", msg_data, true);
-
        /* now wait for completion */
        return ipc4_wait_tx_done(ipc, reply_data);
 }