staging: rtl8188eu: remove unnecessary asignment
authorMichael Straube <straube.linux@gmail.com>
Sun, 5 Apr 2020 11:22:29 +0000 (13:22 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Apr 2020 06:55:32 +0000 (08:55 +0200)
Remove unnecessary asignment in SwLedBlink1(). The code path with the
asignment 'pLed->BlinkTimes = 0' is only executed when
'pLed->BlinkTimes' is already zero and the value is not changed between
the test 'if (pLed->BlinkTimes == 0)' and the asignment.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200405112230.31975-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_led.c

index d1406cc..91b0029 100644 (file)
@@ -188,7 +188,6 @@ static void SwLedBlink1(struct LED_871x *pLed)
                                          msecs_to_jiffies(LED_BLINK_NO_LINK_INTERVAL_ALPHA));
                                RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("CurrLedState %d\n", pLed->CurrLedState));
                        }
-                       pLed->BlinkTimes = 0;
                        pLed->bLedBlinkInProgress = false;
                } else {
                        if (pLed->bLedOn)