staging: bcm2835-camera: Replace deprecated V4L2_PIX_FMT_BGR32
authorDave Stevenson <dave.stevenson@raspberrypi.com>
Thu, 8 Oct 2020 14:35:14 +0000 (15:35 +0100)
committerDom Cobley <popcornmix@gmail.com>
Mon, 19 Feb 2024 11:33:04 +0000 (11:33 +0000)
V4L2_PIX_FMT_BGR32 is deprecated as it is ambiguous over where
the alpha byte is. Cheese/GStreamer appear to get it wrong for
one, and qv4l2 gets red and blue swapped.

Swap to the newer V4L2_PIX_FMT_BGRX32 format.

https://www.raspberrypi.org/forums/viewtopic.php?f=38&t=267736&p=1738912

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c

index 25e2ac4..076f9c4 100644 (file)
@@ -176,7 +176,7 @@ static struct mmal_fmt formats[] = {
                .ybbp = 1,
                .remove_padding = true,
        }, {
-               .fourcc = V4L2_PIX_FMT_BGR32,
+               .fourcc = V4L2_PIX_FMT_BGRX32,
                .mmal = MMAL_ENCODING_BGRA,
                .depth = 32,
                .mmal_component = COMP_CAMERA,