Revise __ms_parse_gst_error()

Remove unnecessary else branch.
Add error log.

[Version] 0.1.113
[Issue Type] Improvement

Change-Id: I5b21eae294bd024d3a46f5e29e7ed0bc43d7be77
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>

diff --git a/packaging/capi-media-streamer.spec b/packaging/capi-media-streamer.spec
index 9aff02c..d71c441 100644 (file)
--- a/packaging/capi-media-streamer.spec
+++ b/packaging/capi-media-streamer.spec
@@ -1,6 +1,6 @@
 Name:       capi-media-streamer
 Summary:    A Media Streamer API
-Version:    0.1.112
+Version:    0.1.113
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0

diff --git a/src/media_streamer_gst.c b/src/media_streamer_gst.c
index f7cb578..e1db8a0 100644 (file)
--- a/src/media_streamer_gst.c
+++ b/src/media_streamer_gst.c
@@ -1890,17 +1890,11 @@ static gboolean __ms_parse_gst_error(media_streamer_s *ms_streamer, GstMessage *
 {
        media_streamer_error_e ret_error = MEDIA_STREAMER_ERROR_NONE;
 
-       ms_debug_fenter();
-
-       ms_retvm_if(!ms_streamer, FALSE, "Error: invalid Media Streamer handle.");
-       ms_retvm_if(!message, FALSE, "Error: invalid bus message handle.");
-       ms_retvm_if(!error, FALSE, "Error: invalid error handle.");
+       ms_retvm_if(!ms_streamer, FALSE, "ms_streamer is NULL");
+       ms_retvm_if(!message, FALSE, "message is NULL");
+       ms_retvm_if(!error, FALSE, "error is NULL");
 
-       if (error->domain == GST_CORE_ERROR)
-               ret_error = MEDIA_STREAMER_ERROR_INVALID_OPERATION;
-       else if (error->domain == GST_LIBRARY_ERROR)
-               ret_error = MEDIA_STREAMER_ERROR_INVALID_OPERATION;
-       else if (error->domain == GST_RESOURCE_ERROR)
+       if (error->domain == GST_RESOURCE_ERROR)
                ret_error = MEDIA_STREAMER_ERROR_RESOURCE_CONFLICT;
        else if (error->domain == GST_STREAM_ERROR)
                ret_error = MEDIA_STREAMER_ERROR_CONNECTION_FAILED;
@@ -1913,7 +1907,7 @@ static gboolean __ms_parse_gst_error(media_streamer_s *ms_streamer, GstMessage *
                error_cb((media_streamer_h) ms_streamer, ret_error, ms_streamer->error_cb.user_data);
        }
 
-       ms_debug_fleave();
+       ms_error("error[%s], ret[0x%x]", error->message, ret_error);
 
        return TRUE;
 }