ext/wavpack/gstwavpackenc.c: Fix mem leak, send newsegment event on correction pad...

Original commit message from CVS:
* ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_push_block):
Fix mem leak, send newsegment event on correction pad
as well (#352476).
* ext/wavpack/gstwavpackparse.c: (gst_wavpack_parse_base_init):
Restore original author (on Sebastian's request).
* tests/check/Makefile.am:
* tests/check/gst-plugins-bad.supp:
Add (so far empty) suppression file for -bad. Remove
wavpackenc test from VALGRIND_TO_FIX now that the leak
is fixed.

diff --git a/ChangeLog b/ChangeLog
index 7f44a2a..6787429 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,20 @@
 2006-08-23  Tim-Philipp Müller  <tim at centricular dot net>
 
+       * ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_push_block):
+         Fix mem leak, send newsegment event on correction pad
+         as well (#352476).
+
+       * ext/wavpack/gstwavpackparse.c: (gst_wavpack_parse_base_init):
+         Restore original author (on Sebastian's request).
+
+       * tests/check/Makefile.am:
+       * tests/check/gst-plugins-bad.supp:
+         Add (so far empty) suppression file for -bad. Remove
+         wavpackenc test from VALGRIND_TO_FIX now that the leak
+         is fixed.
+
+2006-08-23  Tim-Philipp Müller  <tim at centricular dot net>
+
        Patch by: Sebastian Dröge <slomo at circular-chaos.org>
 
        * tests/check/Makefile.am:

diff --git a/common b/common
index e9ea99f..d287125 160000 (submodule)
--- a/common
+++ b/common
@@ -1 +1 @@
-Subproject commit e9ea99f6e89d7e1af3a0a859bfeb0ed6ecf2e3a9
+Subproject commit d287125f93da692bc25d53b0b7b0e2f90424a212

diff --git a/ext/wavpack/gstwavpackenc.c b/ext/wavpack/gstwavpackenc.c
index 19ad092..22d8f97 100644 (file)
--- a/ext/wavpack/gstwavpackenc.c
+++ b/ext/wavpack/gstwavpackenc.c
@@ -562,13 +562,13 @@ gst_wavpack_enc_push_block (void *id, void *data, int32_t count)
 
     /* if it's the first wavpack block, send a NEW_SEGMENT event */
     if (wph.block_index == 0) {
-      GstEvent *event = gst_event_new_new_segment (FALSE,
-          1.0, GST_FORMAT_BYTES, 0, GST_BUFFER_OFFSET_NONE, 0);
+      gst_pad_push_event (pad,
+          gst_event_new_new_segment (FALSE,
+              1.0, GST_FORMAT_BYTES, 0, GST_BUFFER_OFFSET_NONE, 0));
 
       /* save header for later reference, so we can re-send it later on
        * EOS with fixed up values for total sample count etc. */
       if (enc->first_block == NULL && !wid->correction) {
-        gst_pad_push_event (enc->srcpad, event);
         enc->first_block = g_memdup (block, count);
         enc->first_block_size = count;
       }

diff --git a/ext/wavpack/gstwavpackparse.c b/ext/wavpack/gstwavpackparse.c
index ca894ec..d252ccf 100644 (file)
--- a/ext/wavpack/gstwavpackparse.c
+++ b/ext/wavpack/gstwavpackparse.c
@@ -97,7 +97,7 @@ gst_wavpack_parse_base_init (gpointer klass)
       GST_ELEMENT_DETAILS ("WavePack parser",
       "Codec/Demuxer/Audio",
       "Parses Wavpack files",
-      "Sebastian Dröge <slomo@circular-chaos.org>");
+      "Arwed v. Merkatz <v.merkatz@gmx.net>");
   GstElementClass *element_class = GST_ELEMENT_CLASS (klass);
 
   gst_element_class_add_pad_template (element_class,

diff --git a/tests/check/Makefile.am b/tests/check/Makefile.am
index 1c52025..e85d5c8 100644 (file)
--- a/tests/check/Makefile.am
+++ b/tests/check/Makefile.am
@@ -22,7 +22,7 @@ install-pluginLTLIBRARIES:
 # the core dumps of some machines have PIDs appended
 CLEANFILES = core.* test-registry.xml
 
-SUPPRESSIONS = $(top_srcdir)/common/gst.supp
+SUPPRESSIONS = $(top_srcdir)/common/gst.supp $(srcdir)/gst-plugins-bad.supp
 
 clean-local: clean-local-check
 
@@ -42,8 +42,7 @@ check_wavpack =
 endif
 
 VALGRIND_TO_FIX = \
-       elements/mpeg2enc \
-       elements/wavpackenc
+       elements/mpeg2enc
 
 # valgrind testing
 VALGRIND_TESTS_DISABLE = $(VALGRIND_TO_FIX)

diff --git a/tests/check/gst-plugins-bad.supp b/tests/check/gst-plugins-bad.supp
new file mode 100644 (file)
index 0000000..e69de29