Fixed major pylint findings

Change-Id: I37c39665292f32dfa03b89d787641c668dc18a4f
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Reviewed-on: https://otctools.jf.intel.com/review/6368
Tested-by: OTC Tools Tester <ed.bartosh@linux.intel.com>
Reviewed-by: Hasan Wan <hasan.wan@intel.com>

diff --git a/common/buildservice.py b/common/buildservice.py
index 82e7e81..3831991 100644 (file)
--- a/common/buildservice.py
+++ b/common/buildservice.py
@@ -504,7 +504,7 @@ class BuildService(OSC):
             raise ObsError('base project: %s not exists' % src)
 
         if not self.exists(project):
-            raise ObsError('project: %s not exists' % target)
+            raise ObsError('project: %s not exists' % project)
 
         meta_xml = self.get_meta(project)
         xml_root = ElementTree.fromstringlist(meta_xml)
@@ -530,7 +530,7 @@ class BuildService(OSC):
         modify the meta conf to unlink the project
         """
         if not self.exists(project):
-            raise ObsError('project: %s not exists' % target)
+            raise ObsError('project: %s not exists' % project)
 
         meta_xml = self.get_meta(project)
         xml_root = ElementTree.fromstringlist(meta_xml)

diff --git a/job_deletetag.py b/job_deletetag.py
index c4fcfd1..2e42622 100755 (executable)
--- a/job_deletetag.py
+++ b/job_deletetag.py
@@ -43,7 +43,7 @@ def main():
     tmpdir = tempfile.mkdtemp(prefix=(os.getenv('WORKSPACE') + '/'))
     events = get_gerrit_event()
     gerrit = Gerrit(events['hostname'], events['username'],
-                    event['sshport'], int(os.getenv('GERRIT_SILENT_MODE')))
+                    events['sshport'], int(os.getenv('GERRIT_SILENT_MODE')))
     patchs = gerrit.query('change:%s --patch-sets' %
             events['change_number'])
 

diff --git a/job_pre_release_gerrit.py b/job_pre_release_gerrit.py
index 30d39fb..b61ea49 100755 (executable)
--- a/job_pre_release_gerrit.py
+++ b/job_pre_release_gerrit.py
@@ -99,6 +99,8 @@ def create(git_url, git_project, git_tag, git_revision, build,
                          (obs_project, error))
     build.link_project(obs_project, src=obs_target_prj, linktype="localdep")
 
+    return 0
+
 def main(name):
     """
     Script entry point.