dccp: Set TOS and routing scope independently for fib lookups.
authorGuillaume Nault <gnault@redhat.com>
Mon, 17 Jul 2023 13:53:35 +0000 (15:53 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 19 Jul 2023 11:32:07 +0000 (12:32 +0100)
There's no reason for setting the RTO_ONLINK flag in ->flowi4_tos as
RT_CONN_FLAGS() does. We can easily set ->flowi4_scope properly
instead. This makes the code more explicit and will allow to convert
->flowi4_tos to dscp_t in the future.

Signed-off-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dccp/ipv4.c

index fa80793..8e919cf 100644 (file)
@@ -474,7 +474,8 @@ static struct dst_entry* dccp_v4_route_skb(struct net *net, struct sock *sk,
                .flowi4_oif = inet_iif(skb),
                .daddr = iph->saddr,
                .saddr = iph->daddr,
-               .flowi4_tos = RT_CONN_FLAGS(sk),
+               .flowi4_tos = ip_sock_rt_tos(sk),
+               .flowi4_scope = ip_sock_rt_scope(sk),
                .flowi4_proto = sk->sk_protocol,
                .fl4_sport = dccp_hdr(skb)->dccph_dport,
                .fl4_dport = dccp_hdr(skb)->dccph_sport,