soundwire: cadence_master: check the number of bidir PDIs

There is an assumption that the first two PDIs are reserved for Bulk,
so we need to make sure the number of bidir PDIs is indeed larger than
two. If the configuration provided is incorrect, this could lead to
allocating a huge amount of memory.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
index d76dd24..ff4badc 100644 (file)
--- a/drivers/soundwire/cadence_master.c
+++ b/drivers/soundwire/cadence_master.c
@@ -718,6 +718,8 @@ int sdw_cdns_pdi_init(struct sdw_cdns *cdns,
        stream = &cdns->pcm;
 
        /* First two PDIs are reserved for bulk transfers */
+       if (stream->num_bd < CDNS_PCM_PDI_OFFSET)
+               return -EINVAL;
        stream->num_bd -= CDNS_PCM_PDI_OFFSET;
        offset = CDNS_PCM_PDI_OFFSET;