staging: ks7010: refactor ks_wlan_set_mlme function
authorSergio Paracuellos <sergio.paracuellos@gmail.com>
Fri, 4 May 2018 04:16:43 +0000 (06:16 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 May 2018 01:58:40 +0000 (18:58 -0700)
This commit refactors ks_wlan_set_mlme function changing
switch-case block for more simple if paths improving
readability.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ks7010/ks_wlan_net.c

index 62a9d55..30f8cee 100644 (file)
@@ -1787,23 +1787,20 @@ static int ks_wlan_set_mlme(struct net_device *dev,
 {
        struct ks_wlan_private *priv = netdev_priv(dev);
        struct iw_mlme *mlme = (struct iw_mlme *)extra;
-       __u32 mode;
+       __u32 mode = 1;
 
        if (priv->sleep_mode == SLP_SLEEP)
                return -EPERM;
 
-       /* for SLEEP MODE */
-       switch (mlme->cmd) {
-       case IW_MLME_DEAUTH:
-               if (mlme->reason_code == WLAN_REASON_MIC_FAILURE)
-                       return 0;
-               /* fall through */
-       case IW_MLME_DISASSOC:
-               mode = 1;
-               return ks_wlan_set_stop_request(dev, NULL, &mode, NULL);
-       default:
-               return -EOPNOTSUPP;     /* Not Support */
-       }
+       if (mlme->cmd != IW_MLME_DEAUTH &&
+           mlme->cmd != IW_MLME_DISASSOC)
+               return -EOPNOTSUPP;
+
+       if (mlme->cmd == IW_MLME_DEAUTH &&
+           mlme->reason_code == WLAN_REASON_MIC_FAILURE)
+               return 0;
+
+       return ks_wlan_set_stop_request(dev, NULL, &mode, NULL);
 }
 
 static int ks_wlan_get_firmware_version(struct net_device *dev,