bufferpool:check caps argument

Caps should be NULL or fixed when configured in a bufferpool

diff --git a/gst/gstbufferpool.c b/gst/gstbufferpool.c
index d7a09d1..ab212b5 100644 (file)
--- a/gst/gstbufferpool.c
+++ b/gst/gstbufferpool.c
@@ -685,6 +685,7 @@ gst_buffer_pool_config_set_params (GstStructure * config, GstCaps * caps,
 {
   g_return_if_fail (config != NULL);
   g_return_if_fail (max_buffers == 0 || min_buffers <= max_buffers);
+  g_return_if_fail (caps == NULL || gst_caps_is_fixed (caps));
 
   gst_structure_id_set (config,
       GST_QUARK (CAPS), GST_TYPE_CAPS, caps,

diff --git a/gst/gstbufferpool.h b/gst/gstbufferpool.h
index ed26bb5..3527040 100644 (file)
--- a/gst/gstbufferpool.h
+++ b/gst/gstbufferpool.h
@@ -179,7 +179,6 @@ GstStructure *   gst_buffer_pool_get_config      (GstBufferPool *pool);
 const gchar **   gst_buffer_pool_get_options     (GstBufferPool *pool);
 gboolean         gst_buffer_pool_has_option      (GstBufferPool *pool, const gchar *option);
 
-
 /* helpers for configuring the config structure */
 void             gst_buffer_pool_config_set_params    (GstStructure *config, GstCaps *caps,
                                                        guint size, guint min_buffers, guint max_buffers);