Staging: lustre: Unnecessory else and braces are removed
authorVaishali Thakkar <vthakkar1994@gmail.com>
Tue, 23 Sep 2014 13:51:32 +0000 (19:21 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 23 Sep 2014 15:18:59 +0000 (08:18 -0700)
This patch fixes following checkpatch.pl warning using coccinelle:

WARNING: else is not generally useful after a break or return

Semantic patch used for this is as follows:

@rule1@
expression e1;
@@

        if (e1) { ... return ...; }
-       else{
                ...
-       }

@rule2@
expression e2;
statement s1;
@@

        if(e2) { ... return ...; }
-       else
                s1

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/obdclass/capa.c

index 6a4b4d7..cd1abce 100644 (file)
@@ -213,12 +213,11 @@ struct obd_capa *capa_add(struct hlist_head *hash, struct lustre_capa *capa)
                        capa_delete_lru(list);
                spin_unlock(&capa_lock);
                return ocapa;
-       } else {
-               capa_get(old);
-               spin_unlock(&capa_lock);
-               capa_put(ocapa);
-               return old;
        }
+       capa_get(old);
+       spin_unlock(&capa_lock);
+       capa_put(ocapa);
+       return old;
 }
 EXPORT_SYMBOL(capa_add);