pepper-utils: fix pepper_security crash
authorSung-Jin Park <sj76.park@samsung.com>
Fri, 5 Jul 2019 04:09:18 +0000 (13:09 +0900)
committerSung-Jin Park <sj76.park@samsung.com>
Tue, 9 Jul 2019 06:28:16 +0000 (15:28 +0900)
Signed-off-by: Sung-Jin Park <sj76.park@samsung.com>
src/lib/pepper/utils-security.c

index 001ea99..3edca8d 100644 (file)
@@ -89,12 +89,15 @@ pepper_security_privilege_check(pid_t pid, uid_t uid, const char *privilege)
        int ret = -1;
 
        ret = smack_new_label_from_process((int)pid, &client_smack);
-       PEPPER_CHECK(ret > 0, goto finish, "");
+
+       if (ret <= 0)
+               goto finish;
 
        snprintf(uid_str, 15, "%d", (int)uid);
 
        client_session = cynara_session_from_pid(pid);
-       PEPPER_CHECK(client_session, goto finish, "");
+       if (!client_session)
+               goto finish;
 
        ret = cynara_check(g_cynara,
                          client_smack,
@@ -109,7 +112,7 @@ pepper_security_privilege_check(pid_t pid, uid_t uid, const char *privilege)
 
 finish:
        PEPPER_TRACE("Privilege Check For '%s' %s pid:%u uid:%u client_smack:%s(len:%d) client_session:%s ret:%d",
-                                       NULL, privilege, res ? "SUCCESS" : "FAIL", pid, uid,
+                                       privilege, res ? "SUCCESS" : "FAIL", pid, uid,
                                        client_smack ? client_smack : "N/A", len,
                                        client_session ? client_session: "N/A", ret);