n64: use enums for reg
authorChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Mon, 25 Jan 2021 23:32:38 +0000 (15:32 -0800)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Sun, 21 Feb 2021 22:37:52 +0000 (23:37 +0100)
Macros tend to be not type-safe. Use enum for register definitions.

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Lauri Kasanen <cand@gmx.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
drivers/block/n64cart.c

index b18f034..620f9e0 100644 (file)
 #include <linux/module.h>
 #include <linux/platform_device.h>
 
-#define PI_DRAM_REG            0
-#define PI_CART_REG            1
-#define PI_READ_REG            2
-#define PI_WRITE_REG           3
-#define PI_STATUS_REG          4
+enum {
+       PI_DRAM_REG = 0,
+       PI_CART_REG,
+       PI_READ_REG,
+       PI_WRITE_REG,
+       PI_STATUS_REG,
+};
 
 #define PI_STATUS_DMA_BUSY     (1 << 0)
 #define PI_STATUS_IO_BUSY      (1 << 1)