net: ena: Fix XDP redirection error
authorDavid Arinzon <darinzon@amazon.com>
Mon, 11 Dec 2023 06:28:01 +0000 (06:28 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Dec 2023 16:01:49 +0000 (17:01 +0100)
[ Upstream commit 4ab138ca0a340e6d6e7a6a9bd5004bd8f83127ca ]

When sending TX packets, the meta descriptor can be all zeroes
as no meta information is required (as in XDP).

This patch removes the validity check, as when
`disable_meta_caching` is enabled, such TX packets will be
dropped otherwise.

Fixes: 0e3a3f6dacf0 ("net: ena: support new LLQ acceleration mode")
Signed-off-by: Shay Agroskin <shayagr@amazon.com>
Signed-off-by: David Arinzon <darinzon@amazon.com>
Link: https://lore.kernel.org/r/20231211062801.27891-5-darinzon@amazon.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/amazon/ena/ena_eth_com.c

index 3d6f0a4..f9f8862 100644 (file)
@@ -328,9 +328,6 @@ static int ena_com_create_and_store_tx_meta_desc(struct ena_com_io_sq *io_sq,
         * compare it to the stored version, just create the meta
         */
        if (io_sq->disable_meta_caching) {
-               if (unlikely(!ena_tx_ctx->meta_valid))
-                       return -EINVAL;
-
                *have_meta = true;
                return ena_com_create_meta(io_sq, ena_meta);
        }