modpost: detect section mismatch for R_ARM_REL32
authorMasahiro Yamada <masahiroy@kernel.org>
Thu, 1 Jun 2023 12:10:01 +0000 (21:10 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Sat, 3 Jun 2023 16:37:41 +0000 (01:37 +0900)
For ARM, modpost fails to detect some types of section mismatches.

  [test code]

    .section .init.data,"aw"
    bar:
            .long 0

    .section .data,"aw"
    .globl foo
    foo:
            .long bar - .

It is apparently a bad reference, but modpost does not report anything.

The test code above produces the following relocations.

  Relocation section '.rel.data' at offset 0xe8 contains 1 entry:
   Offset     Info    Type            Sym.Value  Sym. Name
  00000000  00000403 R_ARM_REL32       00000000   .init.data

Currently, R_ARM_REL32 is just skipped.

Handle it like R_ARM_ABS32.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/mod/modpost.c

index 4e911ab711d4bf2231bcb0fb37a7f428a16b5055..d10f5bdcb75365f27dfa35cdd1ccdb93e03545ec 100644 (file)
@@ -1281,6 +1281,7 @@ static int addend_arm_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r)
 
        switch (r_typ) {
        case R_ARM_ABS32:
+       case R_ARM_REL32:
                inst = TO_NATIVE(*(uint32_t *)loc);
                r->r_addend = inst + sym->st_value;
                break;