Bluetooth: hci_serdev: clear HCI_UART_PROTO_READY to avoid closing proto races
authorBalakrishna Godavarthi <bgodavar@codeaurora.org>
Wed, 22 Aug 2018 12:04:11 +0000 (17:34 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Nov 2019 17:47:42 +0000 (18:47 +0100)
[ Upstream commit 7cf7846d27bfc9731e449857db3eec5e0e9701ba ]

Clearing HCI_UART_PROTO_READY will avoid usage of proto function pointers
before running the proto close function pointer. There is chance of kernel
crash, due to usage of non proto close function pointers after proto close.

Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/bluetooth/hci_serdev.c

index aa2543b..46e2044 100644 (file)
@@ -368,6 +368,7 @@ void hci_uart_unregister_device(struct hci_uart *hu)
 {
        struct hci_dev *hdev = hu->hdev;
 
+       clear_bit(HCI_UART_PROTO_READY, &hu->flags);
        hci_unregister_dev(hdev);
        hci_free_dev(hdev);