pwm: iqs620a: Use regmap_clear_bits and regmap_set_bits where applicable
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 2 Dec 2022 18:35:16 +0000 (19:35 +0100)
committerThierry Reding <thierry.reding@gmail.com>
Tue, 6 Dec 2022 11:46:09 +0000 (12:46 +0100)
Found using coccinelle and the following semantic patch:

@@
expression map, reg, bits;
@@

- regmap_update_bits(map, reg, bits, bits)
+ regmap_set_bits(map, reg, bits)

@@
expression map, reg, bits;
@@

- regmap_update_bits(map, reg, bits, 0)
+ regmap_clear_bits(map, reg, bits)

Link: https://lore.kernel.org/r/20221115111347.3705732-4-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-iqs620a.c

index 54bd95a..7246176 100644 (file)
@@ -47,8 +47,8 @@ static int iqs620_pwm_init(struct iqs620_pwm_private *iqs620_pwm,
        int ret;
 
        if (!duty_scale)
-               return regmap_update_bits(iqs62x->regmap, IQS620_PWR_SETTINGS,
-                                         IQS620_PWR_SETTINGS_PWM_OUT, 0);
+               return regmap_clear_bits(iqs62x->regmap, IQS620_PWR_SETTINGS,
+                                        IQS620_PWR_SETTINGS_PWM_OUT);
 
        ret = regmap_write(iqs62x->regmap, IQS620_PWM_DUTY_CYCLE,
                           duty_scale - 1);