[HB] Add XXX marks
authorBehdad Esfahbod <behdad@behdad.org>
Sun, 2 Aug 2009 19:20:22 +0000 (15:20 -0400)
committerBehdad Esfahbod <behdad@behdad.org>
Mon, 2 Nov 2009 19:40:26 +0000 (14:40 -0500)
src/hb-ot-layout-private.h
src/hb-ot-layout.cc

index 48e9145..3fdd428 100644 (file)
@@ -28,7 +28,9 @@
 #define HB_OT_LAYOUT_PRIVATE_H
 
 #include "hb-private.h"
+
 #include "hb-ot-layout.h"
+
 #include "hb-buffer-private.h"
 
 
index d04d54d..7e0539a 100644 (file)
 
 #define HB_OT_LAYOUT_CC
 
-/* XXX */
-#include "hb-buffer-private.h"
-
-#include "hb-ot-layout.h"
 #include "hb-ot-layout-private.h"
 
 #include "hb-ot-layout-open-private.h"
@@ -263,7 +259,7 @@ hb_ot_layout_set_glyph_class (hb_ot_layout_t             *layout,
                              hb_codepoint_t              glyph,
                              hb_ot_layout_glyph_class_t  klass)
 {
-  /* TODO optimize this, similar to old harfbuzz code for example */
+  /* TODO optimize this? similar to old harfbuzz code for example */
 
   hb_ot_layout_class_t gdef_klass;
   int len = layout->new_gdef.len;
@@ -271,6 +267,7 @@ hb_ot_layout_set_glyph_class (hb_ot_layout_t             *layout,
   if (HB_UNLIKELY (glyph > 65535))
     return;
 
+  /* XXX this is not threadsafe */
   if (glyph >= len) {
     int new_len;
     unsigned char *new_klasses;