rtc: mc146818-lib: refactor mc146818_does_rtc_work
authorMateusz Jończyk <mat.jonczyk@o2.pl>
Fri, 10 Dec 2021 20:01:29 +0000 (21:01 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 16 Dec 2021 20:50:06 +0000 (21:50 +0100)
Refactor mc146818_does_rtc_work() so that it uses mc146818_avoid_UIP().
It is enough to call mc146818_avoid_UIP() with no callback.

Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20211210200131.153887-8-mat.jonczyk@o2.pl
drivers/rtc/rtc-mc146818-lib.c

index 15604b7..f62e658 100644 (file)
@@ -84,22 +84,7 @@ EXPORT_SYMBOL_GPL(mc146818_avoid_UIP);
  */
 bool mc146818_does_rtc_work(void)
 {
-       int i;
-       unsigned char val;
-       unsigned long flags;
-
-       for (i = 0; i < 10; i++) {
-               spin_lock_irqsave(&rtc_lock, flags);
-               val = CMOS_READ(RTC_FREQ_SELECT);
-               spin_unlock_irqrestore(&rtc_lock, flags);
-
-               if ((val & RTC_UIP) == 0)
-                       return true;
-
-               mdelay(1);
-       }
-
-       return false;
+       return mc146818_avoid_UIP(NULL, NULL);
 }
 EXPORT_SYMBOL_GPL(mc146818_does_rtc_work);