ALSA: usb: Remove superfluous snd_pcm_suspend*() calls
authorTakashi Iwai <tiwai@suse.de>
Fri, 11 Jan 2019 17:03:16 +0000 (18:03 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 15 Jan 2019 16:47:32 +0000 (17:47 +0100)
The call of snd_pcm_suspend_all() & co became superfluous since we
call it in the PCM PM ops.  Let's remove them.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/card.c
sound/usb/line6/driver.c

index a105947..dfa38b7 100644 (file)
@@ -811,7 +811,6 @@ static int usb_audio_suspend(struct usb_interface *intf, pm_message_t message)
                snd_power_change_state(chip->card, SNDRV_CTL_POWER_D3hot);
        if (!chip->num_suspended_intf++) {
                list_for_each_entry(as, &chip->pcm_list, list) {
-                       snd_pcm_suspend_all(as->pcm);
                        snd_usb_pcm_suspend(as);
                        as->substream[0].need_setup_ep =
                                as->substream[1].need_setup_ep = true;
index c1376bf..7afe8fa 100644 (file)
@@ -849,10 +849,8 @@ int line6_suspend(struct usb_interface *interface, pm_message_t message)
        if (line6->properties->capabilities & LINE6_CAP_CONTROL)
                line6_stop_listen(line6);
 
-       if (line6pcm != NULL) {
-               snd_pcm_suspend_all(line6pcm->pcm);
+       if (line6pcm != NULL)
                line6pcm->flags = 0;
-       }
 
        return 0;
 }