Staging: rtlwifi: Remove Unneeded funition halbtc_get_wifi_rssi()
authorBhanusree Pola <bhanusreemahesh@gmail.com>
Tue, 23 Oct 2018 10:57:26 +0000 (16:27 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Nov 2018 13:16:32 +0000 (14:16 +0100)
In the function halbtc_get_wifi_rssi:

1.if and else are functionally identical as they assign same value to
  variable 'undec_sm_pwdb'.
2.Variable 'undec_sm_pwdb' not required to just return a single value.
3.Function not needed to just return a value and so removed the function
  and assigned value rtlpriv->dm.undec_sm_pwdb where the function
  halbtc_get_wifi_rssi() is called.

Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c

index 24e19ff..b519d18 100644 (file)
@@ -476,17 +476,6 @@ static u32 halbtc_get_wifi_link_status(struct btc_coexist *btcoexist)
        return ret_val;
 }
 
-static s32 halbtc_get_wifi_rssi(struct rtl_priv *rtlpriv)
-{
-       int undec_sm_pwdb = 0;
-
-       if (rtlpriv->mac80211.link_state >= MAC80211_LINKED)
-               undec_sm_pwdb = rtlpriv->dm.undec_sm_pwdb;
-       else /* associated entry pwdb */
-               undec_sm_pwdb = rtlpriv->dm.undec_sm_pwdb;
-       return undec_sm_pwdb;
-}
-
 static bool halbtc_get(void *void_btcoexist, u8 get_type, void *out_buf)
 {
        struct btc_coexist *btcoexist = (struct btc_coexist *)void_btcoexist;
@@ -585,7 +574,7 @@ static bool halbtc_get(void *void_btcoexist, u8 get_type, void *out_buf)
                *bool_tmp = false;
                break;
        case BTC_GET_S4_WIFI_RSSI:
-               *s32_tmp = halbtc_get_wifi_rssi(rtlpriv);
+               *s32_tmp = rtlpriv->dm.undec_sm_pwdb;
                break;
        case BTC_GET_S4_HS_RSSI:
                *s32_tmp = 0;