ACPI/PCI: Remove useless NULL pointer checks
authorAndrey Strachuk <strochuk@ispras.ru>
Thu, 21 Jul 2022 14:11:33 +0000 (17:11 +0300)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 27 Jul 2022 19:21:27 +0000 (21:21 +0200)
Local variable 'p' is initialized by an address of field of acpi_resource,
so it does not make sense to compare 'p' with NULL.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Andrey Strachuk <strochuk@ispras.ru>
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/pci_link.c

index 5864705..aa1038b 100644 (file)
@@ -95,7 +95,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource,
        case ACPI_RESOURCE_TYPE_IRQ:
                {
                        struct acpi_resource_irq *p = &resource->data.irq;
-                       if (!p || !p->interrupt_count) {
+                       if (!p->interrupt_count) {
                                acpi_handle_debug(handle,
                                                  "Blank _PRS IRQ resource\n");
                                return AE_OK;
@@ -121,7 +121,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource,
                {
                        struct acpi_resource_extended_irq *p =
                            &resource->data.extended_irq;
-                       if (!p || !p->interrupt_count) {
+                       if (!p->interrupt_count) {
                                acpi_handle_debug(handle,
                                                  "Blank _PRS EXT IRQ resource\n");
                                return AE_OK;
@@ -182,7 +182,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource,
        case ACPI_RESOURCE_TYPE_IRQ:
                {
                        struct acpi_resource_irq *p = &resource->data.irq;
-                       if (!p || !p->interrupt_count) {
+                       if (!p->interrupt_count) {
                                /*
                                 * IRQ descriptors may have no IRQ# bits set,
                                 * particularly those w/ _STA disabled
@@ -197,7 +197,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource,
                {
                        struct acpi_resource_extended_irq *p =
                            &resource->data.extended_irq;
-                       if (!p || !p->interrupt_count) {
+                       if (!p->interrupt_count) {
                                /*
                                 * extended IRQ descriptors must
                                 * return at least 1 IRQ