g_menu_model_get_item_link: be careful with refs

Don't unref the hashtable until after we already take the ref on the
value that was contained in the hashtable, otherwise we may kill the
value.

diff --git a/gio/gmenumodel.c b/gio/gmenumodel.c
index 4b6d4bc..79e73be 100644 (file)
--- a/gio/gmenumodel.c
+++ b/gio/gmenumodel.c
@@ -393,10 +393,13 @@ g_menu_model_real_get_item_link (GMenuModel  *model,
   else
     g_assert_not_reached ();
 
+  if (value != NULL)
+    g_object_ref (value);
+
   if (table != NULL)
     g_hash_table_unref (table);
 
-  return value ? g_object_ref (value) : NULL;
+  return value;
 }
 
 static void