mlxsw: spectrum_flow: Convert a goto to a return
authorPetr Machata <petrm@mellanox.com>
Fri, 10 Jul 2020 21:55:10 +0000 (00:55 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 14 Jul 2020 00:22:22 +0000 (17:22 -0700)
No clean-up is performed at the target label of this goto. Convert it to a
direct return.

Signed-off-by: Petr Machata <petrm@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum_flow.c

index 47b66f3..421581a 100644 (file)
@@ -219,8 +219,7 @@ static int mlxsw_sp_setup_tc_block_bind(struct mlxsw_sp_port *mlxsw_sp_port,
                                               mlxsw_sp_tc_block_release);
                if (IS_ERR(block_cb)) {
                        mlxsw_sp_flow_block_destroy(flow_block);
-                       err = PTR_ERR(block_cb);
-                       goto err_cb_register;
+                       return PTR_ERR(block_cb);
                }
                register_block = true;
        } else {
@@ -247,7 +246,6 @@ static int mlxsw_sp_setup_tc_block_bind(struct mlxsw_sp_port *mlxsw_sp_port,
 err_block_bind:
        if (!flow_block_cb_decref(block_cb))
                flow_block_cb_free(block_cb);
-err_cb_register:
        return err;
 }