media: platform/sh_veu.c: remove redundant NULL pointer checks
authorShaobo He <shaobo@cs.utah.edu>
Thu, 28 Feb 2019 22:54:06 +0000 (17:54 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 19 Mar 2019 17:49:19 +0000 (13:49 -0400)
Function `sh_veu_find_fmt` returns an address that is an addition of a
base pointer `sh_veu_fmt` and an offset. The base pointer refers to a
global variable of which address cannot be NULL. Therefore, this commit
removes the NULL pointer checks on the return values of function
`sh_veu_find_fmt`.

Signed-off-by: Shaobo He <shaobo@cs.utah.edu>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/sh_veu.c

index d277cc6..5a9ba05 100644 (file)
@@ -493,9 +493,6 @@ static int sh_veu_try_fmt_vid_cap(struct file *file, void *priv,
        const struct sh_veu_format *fmt;
 
        fmt = sh_veu_find_fmt(f);
-       if (!fmt)
-               /* wrong buffer type */
-               return -EINVAL;
 
        return sh_veu_try_fmt(f, fmt);
 }
@@ -506,9 +503,6 @@ static int sh_veu_try_fmt_vid_out(struct file *file, void *priv,
        const struct sh_veu_format *fmt;
 
        fmt = sh_veu_find_fmt(f);
-       if (!fmt)
-               /* wrong buffer type */
-               return -EINVAL;
 
        return sh_veu_try_fmt(f, fmt);
 }