Return EBADF when trying to read from an uninitalized device
authorPeter Hutterer <peter.hutterer@who-t.net>
Sat, 31 Aug 2013 02:33:33 +0000 (12:33 +1000)
committerPeter Hutterer <peter.hutterer@who-t.net>
Sat, 31 Aug 2013 03:17:26 +0000 (13:17 +1000)
All other functions that check the fd for validity return EBADF, which also makes it
easier to debug if the actual device goes away.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
libevdev/libevdev.c

index 436f7a9..1c99e1f 100644 (file)
@@ -663,7 +663,7 @@ libevdev_next_event(struct libevdev *dev, unsigned int flags, struct input_event
        int rc = 0;
 
        if (dev->fd < 0)
-               return -ENODEV;
+               return -EBADF;
 
        if (!(flags & (LIBEVDEV_READ_NORMAL|LIBEVDEV_READ_SYNC|LIBEVDEV_FORCE_SYNC)))
                return -EINVAL;