RDMA/rxe: Delete error messages triggered by incoming Read requests
authorDaisuke Matsuda <matsuda-daisuke@fujitsu.com>
Mon, 29 Aug 2022 07:12:18 +0000 (16:12 +0900)
committerLeon Romanovsky <leonro@nvidia.com>
Wed, 31 Aug 2022 06:57:09 +0000 (09:57 +0300)
An incoming Read request causes multiple Read responses. If a user MR to
copy data from is unavailable or responder cannot send a reply, then the
error messages can be printed for each response attempt, resulting in
message overflow.

Link: https://lore.kernel.org/r/20220829071218.1639065-1-matsuda-daisuke@fujitsu.com
Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/sw/rxe/rxe_resp.c

index b36ec5c..7c336db 100644 (file)
@@ -809,10 +809,8 @@ static enum resp_states read_reply(struct rxe_qp *qp,
        if (!skb)
                return RESPST_ERR_RNR;
 
-       err = rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt),
-                         payload, RXE_FROM_MR_OBJ);
-       if (err)
-               pr_err("Failed copying memory\n");
+       rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt),
+                   payload, RXE_FROM_MR_OBJ);
        if (mr)
                rxe_put(mr);
 
@@ -823,10 +821,8 @@ static enum resp_states read_reply(struct rxe_qp *qp,
        }
 
        err = rxe_xmit_packet(qp, &ack_pkt, skb);
-       if (err) {
-               pr_err("Failed sending RDMA reply.\n");
+       if (err)
                return RESPST_ERR_RNR;
-       }
 
        res->read.va += payload;
        res->read.resid -= payload;