ARM: dts: imx: Fix the SPI chipselect polarity
authorFabio Estevam <festevam@gmail.com>
Wed, 19 Aug 2020 21:04:24 +0000 (18:04 -0300)
committerShawn Guo <shawnguo@kernel.org>
Sun, 30 Aug 2020 01:37:20 +0000 (09:37 +0800)
The conversion of the spi-imx driver to use GPIO descriptors
in commit 8cdcd8aeee28 ("spi: imx/fsl-lpspi: Convert to GPIO descriptors")
helped to detect the following SPI chipselect polarity mismatch on an
imx6q-sabresd:

[    4.854337] m25p80@0 enforce active low on chipselect handle

Prior to the above commit, the chipselect polarity passed via cs-gpios
property was ignored and considered active-low.

The reason for such mismatch is clearly explained in the comments inside
drivers/gpio/gpiolib-of.c:

 * SPI children have active low chip selects
 * by default. This can be specified negatively
 * by just omitting "spi-cs-high" in the
 * device node, or actively by tagging on
 * GPIO_ACTIVE_LOW as flag in the device
 * tree. If the line is simultaneously
 * tagged as active low in the device tree
 * and has the "spi-cs-high" set, we get a
 * conflict and the "spi-cs-high" flag will
 * take precedence.

To properly represent the SPI chipselect polarity, change it to active-low
when the "spi-cs-high" property is absent.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
56 files changed:
arch/arm/boot/dts/imx27-phytec-phycard-s-som.dtsi
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
arch/arm/boot/dts/imx50-evk.dts
arch/arm/boot/dts/imx51-apf51dev.dts
arch/arm/boot/dts/imx53-m53menlo.dts
arch/arm/boot/dts/imx53-smd.dts
arch/arm/boot/dts/imx53-tqma53.dtsi
arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi
arch/arm/boot/dts/imx6dl-aristainetos_4.dts
arch/arm/boot/dts/imx6dl-eckelmann-ci4x10.dts
arch/arm/boot/dts/imx6dl-prtrvt.dts
arch/arm/boot/dts/imx6dl-prtvt7.dts
arch/arm/boot/dts/imx6q-ba16.dtsi
arch/arm/boot/dts/imx6q-bx50v3.dtsi
arch/arm/boot/dts/imx6q-cm-fx6.dts
arch/arm/boot/dts/imx6q-dhcom-som.dtsi
arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
arch/arm/boot/dts/imx6q-dms-ba16.dts
arch/arm/boot/dts/imx6q-gw5400-a.dts
arch/arm/boot/dts/imx6q-kontron-samx6i.dtsi
arch/arm/boot/dts/imx6q-prti6q.dts
arch/arm/boot/dts/imx6q-var-dt6customboard.dts
arch/arm/boot/dts/imx6qdl-apalis.dtsi
arch/arm/boot/dts/imx6qdl-aristainetos.dtsi
arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi
arch/arm/boot/dts/imx6qdl-colibri.dtsi
arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi
arch/arm/boot/dts/imx6qdl-emcon.dtsi
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
arch/arm/boot/dts/imx6qdl-gw560x.dtsi
arch/arm/boot/dts/imx6qdl-gw5910.dtsi
arch/arm/boot/dts/imx6qdl-gw5912.dtsi
arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
arch/arm/boot/dts/imx6qdl-kontron-samx6i.dtsi
arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
arch/arm/boot/dts/imx6qdl-pico.dtsi
arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
arch/arm/boot/dts/imx6qdl-sabresd.dtsi
arch/arm/boot/dts/imx6qdl-ts4900.dtsi
arch/arm/boot/dts/imx6qdl-ts7970.dtsi
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
arch/arm/boot/dts/imx6sl-evk.dts
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi
arch/arm/boot/dts/imx6ul-kontron-n6x1x-som-common.dtsi
arch/arm/boot/dts/imx6ul-phytec-segin.dtsi
arch/arm/boot/dts/imx6ull-colibri.dtsi
arch/arm/boot/dts/imx7-colibri.dtsi
arch/arm/boot/dts/imx7d-sdb.dts
arch/arm/boot/dts/imx7d-zii-rmu2.dts
arch/arm/boot/dts/imx7d-zii-rpu2.dts

index 52c9524..303f920 100644 (file)
@@ -18,8 +18,8 @@
 };
 
 &cspi1 {
-       cs-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>,
-                  <&gpio4 27 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 28 GPIO_ACTIVE_LOW>,
+                  <&gpio4 27 GPIO_ACTIVE_LOW>;
        status = "okay";
 };
 
index bf883e4..344e777 100644 (file)
@@ -65,7 +65,7 @@
 
 &cspi1 {
        pinctrl-0 = <&pinctrl_cspi1>, <&pinctrl_cspi1cs1>;
-       cs-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>,
+       cs-gpios = <&gpio4 28 GPIO_ACTIVE_LOW>,
                   <&gpio4 27 GPIO_ACTIVE_LOW>;
 };
 
index a25da41..878e89c 100644 (file)
@@ -20,7 +20,7 @@
 &cspi {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_cspi>;
-       cs-gpios = <&gpio4 11 0>, <&gpio4 13 0>;
+       cs-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>, <&gpio4 13 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        flash: m25p32@1 {
index 563c1aa..c66f274 100644 (file)
@@ -74,8 +74,8 @@
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>,
-                  <&gpio4 25 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>,
+                  <&gpio4 25 GPIO_ACTIVE_LOW>;
        status = "okay";
 };
 
index 719ed5c..f98691a 100644 (file)
 &ecspi2 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>, <&gpio2 27 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>, <&gpio2 27 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        spidev@0 {
index ec9fb89..9be44e8 100644 (file)
@@ -58,7 +58,7 @@
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio2 30 0>, <&gpio3 19 0>;
+       cs-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>, <&gpio3 19 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        zigbee: mc1323@0 {
index 9a6cb13..7e7f9f3 100644 (file)
@@ -50,8 +50,8 @@
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio2 30 0>, <&gpio3 19 0>,
-                  <&gpio3 24 0>, <&gpio3 25 0>;
+       cs-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>, <&gpio3 19 GPIO_ACTIVE_LOW>,
+                  <&gpio3 24 GPIO_ACTIVE_LOW>, <&gpio3 25 GPIO_ACTIVE_LOW>;
        status = "disabled";
 };
 
 &cspi {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_cspi>;
-       cs-gpios = <&gpio1 18 0>, <&gpio1 19 0>,
-                  <&gpio1 21 0>;
+       cs-gpios = <&gpio1 18 GPIO_ACTIVE_LOW>, <&gpio1 19 GPIO_ACTIVE_LOW>,
+                  <&gpio1 21 GPIO_ACTIVE_LOW>;
        status = "disabled";
 };
 
index 289feab..24859d0 100644 (file)
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio2 30 0>, <&gpio3 19 0>, <&gpio2 16 0>, <&gpio2 17 0>;
+       cs-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>, <&gpio3 19 GPIO_ACTIVE_LOW>,
+                  <&gpio2 16 GPIO_ACTIVE_LOW>, <&gpio2 17 GPIO_ACTIVE_LOW>;
        status = "okay";
 };
 
index 809ca56..5c7e853 100644 (file)
@@ -61,7 +61,7 @@
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "okay";
index 9eb2b73..b4a9523 100644 (file)
@@ -67,7 +67,7 @@
 &ecspi2 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
-       cs-gpios = <&gpio5 12 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio5 12 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        flash@0 {
@@ -80,7 +80,7 @@
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio5 25 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio5 25 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        tpm@0 {
index fa88245..5ac8444 100644 (file)
@@ -37,7 +37,7 @@
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
@@ -52,7 +52,7 @@
 };
 
 &ecspi3 {
-       cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
        status = "okay";
index 306b4f7..ae6da24 100644 (file)
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "okay";
index fc81f2f..e4578ed 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index 1fb67cd..02812e6 100644 (file)
 };
 
 &ecspi5 {
-       cs-gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi5>;
        status = "okay";
index cab9e92..bfb530f 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>, <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>, <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index 87f0aa8..236fc20 100644 (file)
@@ -59,7 +59,7 @@
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>, <&gpio4 11 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>, <&gpio4 11 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index f9df207..fa2307d 100644 (file)
@@ -99,7 +99,7 @@
 &ecspi5 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi5>;
-       cs-gpios = <&gpio1 12 0>;
+       cs-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        flash: m25p80@0 {
index 57761f3..48fb47e 100644 (file)
@@ -42,7 +42,7 @@
 };
 
 &ecspi5 {
-       cs-gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi5>;
        status = "okay";
index b6e2b58..4cde45d 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index 2618ecc..1a6dcf7 100644 (file)
@@ -15,9 +15,9 @@
 /* Quad/Dual SoMs have 3 chip-select signals */
 &ecspi4 {
        fsl,spi-num-chipselects = <3>;
-       cs-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>,
-                  <&gpio3 29 GPIO_ACTIVE_HIGH>,
-                  <&gpio3 25 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>,
+                  <&gpio3 29 GPIO_ACTIVE_LOW>,
+                  <&gpio3 25 GPIO_ACTIVE_LOW>;
 };
 
 &pinctrl_ecspi4 {
index de6cbaa..d112b50 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>, <&gpio4 25 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>, <&gpio4 25 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2 &pinctrl_ecspi2_cs>;
        status = "okay";
 };
 
 &ecspi3 {
-       cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
        status = "okay";
index a57c2e3..6355035 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio4 9 GPIO_ACTIVE_HIGH>,
-                  <&gpio4 10 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>,
+                  <&gpio4 10 GPIO_ACTIVE_LOW>;
        status = "okay";
 };
 
index dbdd7db..30fa349 100644 (file)
 
 /* Apalis SPI1 */
 &ecspi1 {
-       cs-gpios = <&gpio5 25 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio5 25 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "disabled";
 
 /* Apalis SPI2 */
 &ecspi2 {
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "disabled";
index d954661..e21f6ac 100644 (file)
@@ -91,7 +91,7 @@
 };
 
 &ecspi4 {
-       cs-gpios = <&gpio3 20 0>;
+       cs-gpios = <&gpio3 20 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi4>;
        status = "okay";
index d38630d..ead7ba2 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio4 9 GPIO_ACTIVE_HIGH
-                   &gpio4 10 GPIO_ACTIVE_HIGH
-                   &gpio4 11 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 9 GPIO_ACTIVE_LOW
+                   &gpio4 10 GPIO_ACTIVE_LOW
+                   &gpio4 11 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH &gpio2 27 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW &gpio2 27 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "okay";
 };
 
 &ecspi4 {
-       cs-gpios = <&gpio3 29 GPIO_ACTIVE_HIGH &gpio5 2 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 29 GPIO_ACTIVE_LOW &gpio5 2 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi4>;
        status = "okay";
index 0930194..4e2a309 100644 (file)
@@ -94,7 +94,7 @@
 
 /* Colibri SSP */
 &ecspi4 {
-       cs-gpios = <&gpio5 2 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio5 2 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi4>;
        status = "disabled";
index ebe7a8b..648f5fc 100644 (file)
@@ -30,7 +30,7 @@
 };
 
 &ecspi3 {
-       cs-gpios = <&gpio4 24 0>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
        status = "okay";
index 35e230f..7228b89 100644 (file)
 &ecspi2 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>,
-               <&gpio2 27 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>,
+               <&gpio2 27 GPIO_ACTIVE_LOW>;
 };
 
 &ecspi4 {
index a46ea98..f6182a9 100644 (file)
 };
 
 &ecspi3 {
-       cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
        status = "okay";
index b5f934b..55f368e 100644 (file)
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "okay";
index d6b0745..f68f9da 100644 (file)
 };
 
 &ecspi3 {
-       cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
        status = "okay";
index 11f84ee..6c943a5 100644 (file)
 
 
 &ecspi3 {
-       cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
        status = "okay";
index 0a1ffff..441d8ce 100644 (file)
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "okay";
index e423133..eb1ad28 100644 (file)
 &ecspi2 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_hummingboard2_ecspi2>;
-       cs-gpios = <&gpio2 26 0>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>;
        status = "okay";
 };
 
index 81c7ebb..265f5f3 100644 (file)
 &ecspi2 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>,
-                  <&gpio2 27 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>,
+                  <&gpio2 27 GPIO_ACTIVE_LOW>;
 };
 
 /* SPI0 */
 &ecspi4 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi4>;
-       cs-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>,
-                  <&gpio3 29 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>,
+                  <&gpio3 29 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        /* default boot source: workaround #1 for errata ERR006282 */
index 185a1a3..a091782 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index 4bbe54e..92d09a3 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index c63e1bc..1243677 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 0>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index bc43c75..e361df2 100644 (file)
@@ -71,7 +71,7 @@
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
        status = "okay";
-       cs-gpios = <&gpio4 24 0>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
 
        som_flash: flash@0 {
                compatible = "m25p80", "jedec,spi-nor";
index 39dfd90..5de4ccb 100644 (file)
 &ecspi2 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
-       cs-gpios = <&gpio2 27 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 27 GPIO_ACTIVE_LOW>;
        status = "okay";
 };
 
index 55f736d..afe477f 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 0>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1 &pinctrl_ecspi1_cs>;
        status = "disabled"; /* pin conflict with WEIM NOR */
index 95f9dda..fdc3aa9 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 0>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index 7dddcab..f824c9a 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio4 9 0>;
+       cs-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index 267c956..f88da75 100644 (file)
@@ -95,7 +95,7 @@
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio6 2 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio6 2 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "okay";
index f0be516..e6aa0c3 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
 
 &ecspi2 {
        cs-gpios = <
-               &gpio5 31 GPIO_ACTIVE_HIGH
-               &gpio7 12 GPIO_ACTIVE_HIGH
-               &gpio5 18 GPIO_ACTIVE_HIGH
+               &gpio5 31 GPIO_ACTIVE_LOW
+               &gpio7 12 GPIO_ACTIVE_LOW
+               &gpio5 18 GPIO_ACTIVE_LOW
        >;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
index 5af9ce9..66b1574 100644 (file)
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        flash@0 {
index b1b069e..7a38275 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio4 11 0>;
+       cs-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index d25e27d..5547916 100644 (file)
@@ -93,7 +93,7 @@
 &ecspi4 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi4>;
-       cs-gpios = <&gpio7 4 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio7 4 GPIO_ACTIVE_LOW>;
        status = "okay";
 };
 
index a35be2a..770f59b 100644 (file)
@@ -84,7 +84,7 @@
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio4 26 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 26 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index 61ba21a..2a449a3 100644 (file)
@@ -14,7 +14,7 @@
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio4 22 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "okay";
index 8d5f8dc..f1513e6 100644 (file)
 &ecspi3 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
-       cs-gpios = <&gpio1 20 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio1 20 GPIO_ACTIVE_LOW>;
        status = "disabled";
 };
 
index 6cf9593..4436556 100644 (file)
@@ -68,7 +68,7 @@
 
 /* Colibri SPI */
 &ecspi1 {
-       cs-gpios = <&gpio3 26 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 26 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1 &pinctrl_ecspi1_cs>;
 };
index e18e89d..62b771c 100644 (file)
@@ -60,7 +60,7 @@
 &ecspi3 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3 &pinctrl_ecspi3_cs>;
-       cs-gpios = <&gpio4 11 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>;
 };
 
 &fec1 {
index b50b19f..ac0751b 100644 (file)
 &ecspi3 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
-       cs-gpios = <&gpio5 9 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        tsc2046@0 {
index e5e20b0..331b6d2 100644 (file)
@@ -39,7 +39,7 @@
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 19 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        flash@0 {
index cbf0dbb..893bd30 100644 (file)
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 19 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        flash@0 {