nbd: fix a block_device refcount leak in nbd_release
authorChristoph Hellwig <hch@lst.de>
Mon, 9 Nov 2020 17:30:59 +0000 (18:30 +0100)
committerJens Axboe <axboe@kernel.dk>
Tue, 10 Nov 2020 15:01:28 +0000 (08:01 -0700)
bdget_disk needs to be paired with bdput to not leak a reference
on the block device inode.

Fixes: 08ba91ee6e2c ("nbd: Add the nbd NBD_DISCONNECT_ON_CLOSE config flag.")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/nbd.c

index c4f9ccf..aaae922 100644 (file)
@@ -1518,6 +1518,7 @@ static void nbd_release(struct gendisk *disk, fmode_t mode)
        if (test_bit(NBD_RT_DISCONNECT_ON_CLOSE, &nbd->config->runtime_flags) &&
                        bdev->bd_openers == 0)
                nbd_disconnect_and_put(nbd);
+       bdput(bdev);
 
        nbd_config_put(nbd);
        nbd_put(nbd);