gpiolib: remove an unnecessary TODO
authorBartosz Golaszewski <brgl@bgdev.pl>
Mon, 16 Jul 2018 08:34:24 +0000 (10:34 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 16 Jul 2018 13:41:26 +0000 (15:41 +0200)
It's actually fine to read values of output lines. This was also
allowed by the legacy sysfs interface.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib.c

index c507cd3..464d5ba 100644 (file)
@@ -431,7 +431,7 @@ static long linehandle_ioctl(struct file *filep, unsigned int cmd,
        int i;
 
        if (cmd == GPIOHANDLE_GET_LINE_VALUES_IOCTL) {
-               /* TODO: check if descriptors are really input */
+               /* NOTE: It's ok to read values of output lines. */
                int ret = gpiod_get_array_value_complex(false,
                                                        true,
                                                        lh->numdescs,