[SCSI] hpsa: clarify messages around reset behavior
authorStephen M. Cameron <scameron@beardog.cce.hp.com>
Tue, 3 May 2011 19:59:36 +0000 (14:59 -0500)
committerJames Bottomley <jbottomley@parallels.com>
Tue, 17 May 2011 07:06:11 +0000 (11:06 +0400)
When waiting for the board to become "not ready"
don't print a message saying "waiting for board to
become ready" (possibly followed by a message saying
"failed waiting for board to become not ready".  Instead,
it should be "waiting for board to reset" and "failed
waiting for board to reset."

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: James Bottomley <jbottomley@parallels.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/hpsa.c

index 97db2e5..2a90e9a 100644 (file)
@@ -3334,11 +3334,11 @@ static __devinit int hpsa_kdump_hard_reset_controller(struct pci_dev *pdev)
        msleep(HPSA_POST_RESET_PAUSE_MSECS);
 
        /* Wait for board to become not ready, then ready. */
-       dev_info(&pdev->dev, "Waiting for board to become ready.\n");
+       dev_info(&pdev->dev, "Waiting for board to reset.\n");
        rc = hpsa_wait_for_board_state(pdev, vaddr, BOARD_NOT_READY);
        if (rc)
                dev_warn(&pdev->dev,
-                       "failed waiting for board to become not ready\n");
+                       "failed waiting for board to reset\n");
        rc = hpsa_wait_for_board_state(pdev, vaddr, BOARD_READY);
        if (rc) {
                dev_warn(&pdev->dev,
@@ -3837,6 +3837,7 @@ static __devinit int hpsa_init_reset_devices(struct pci_dev *pdev)
                return -ENODEV;
 
        /* Now try to get the controller to respond to a no-op */
+       dev_warn(&pdev->dev, "Waiting for controller to respond to no-op\n");
        for (i = 0; i < HPSA_POST_RESET_NOOP_RETRIES; i++) {
                if (hpsa_noop(pdev) == 0)
                        break;