iwlwifi: mvm: start to remove the code for d0i3
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Thu, 6 Jun 2019 06:52:56 +0000 (09:52 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 6 Sep 2019 12:31:13 +0000 (15:31 +0300)
For runtime PM to work with d0i3 code, a lot of integration work needs
to be done with the platform (e.g. the out-of-band wake up interrupt)
and we currently don't have any platforms where this integration
happened.  So, this code has been pretty much stale for a while and
when someone enables it, it just breaks things.

Therefore, to simplify the code base and make sure no one enables this
by mistake, we will remove the whole code.

This is only the very start, much more work is needed.
Remove the places where we check iwl_mvm_is_d0i3_supported
but leave all the refs, those will be removed in a different
patch.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c

index 3d63cc4c9eafaca43b8ee38deac71a8d1b859136..a7ed4e85cf8f0b87b26c6d5eb35053c60fa57d14 100644 (file)
@@ -762,12 +762,6 @@ int iwl_mvm_mac_setup_register(struct iwl_mvm *mvm)
        mvm->rts_threshold = IEEE80211_MAX_RTS_THRESHOLD;
 
 #ifdef CONFIG_PM_SLEEP
-       if (iwl_mvm_is_d0i3_supported(mvm) &&
-           device_can_wakeup(mvm->trans->dev)) {
-               mvm->wowlan.flags = WIPHY_WOWLAN_ANY;
-               hw->wiphy->wowlan = &mvm->wowlan;
-       }
-
        if ((unified || mvm->fw->img[IWL_UCODE_WOWLAN].num_sec) &&
            mvm->trans->ops->d3_suspend &&
            mvm->trans->ops->d3_resume &&
@@ -1359,17 +1353,6 @@ static void iwl_mvm_restart_complete(struct iwl_mvm *mvm)
        mutex_unlock(&mvm->mutex);
 }
 
-static void iwl_mvm_resume_complete(struct iwl_mvm *mvm)
-{
-       if (iwl_mvm_is_d0i3_supported(mvm) &&
-           iwl_mvm_enter_d0i3_on_suspend(mvm))
-               WARN_ONCE(!wait_event_timeout(mvm->d0i3_exit_waitq,
-                                             !test_bit(IWL_MVM_STATUS_IN_D0I3,
-                                                       &mvm->status),
-                                             HZ),
-                         "D0i3 exit on resume timed out\n");
-}
-
 static void
 iwl_mvm_mac_reconfig_complete(struct ieee80211_hw *hw,
                              enum ieee80211_reconfig_type reconfig_type)
@@ -1381,7 +1364,6 @@ iwl_mvm_mac_reconfig_complete(struct ieee80211_hw *hw,
                iwl_mvm_restart_complete(mvm);
                break;
        case IEEE80211_RECONFIG_TYPE_SUSPEND:
-               iwl_mvm_resume_complete(mvm);
                break;
        }
 }