staging: gdm724x: Replace macro GDM_TTY_READY with static inline function
authorBrent Pappas <bpappas@pappasbrent.com>
Thu, 17 Nov 2022 19:54:43 +0000 (14:54 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Nov 2022 12:20:16 +0000 (13:20 +0100)
Replace the macro GDM_TTY_READY with a static inline function
to follow the Linux kernel coding style.

Signed-off-by: Brent Pappas <bpappas@pappasbrent.com>
Link: https://lore.kernel.org/r/20221117195443.19616-1-bpappas@pappasbrent.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gdm724x/gdm_tty.c

index cc6d805..e1a84d6 100644 (file)
 
 #define MUX_TX_MAX_SIZE 2048
 
-#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count)
+static inline bool gdm_tty_ready(struct gdm *gdm)
+{
+       return gdm && gdm->tty_dev && gdm->port.count;
+}
 
 static struct tty_driver *gdm_driver[TTY_MAX_COUNT];
 static struct gdm *gdm_table[TTY_MAX_COUNT][GDM_TTY_MINOR];
@@ -113,7 +116,7 @@ static int gdm_tty_recv_complete(void *data,
 {
        struct gdm *gdm = tty_dev->gdm[index];
 
-       if (!GDM_TTY_READY(gdm)) {
+       if (!gdm_tty_ready(gdm)) {
                if (complete == RECV_PACKET_PROCESS_COMPLETE)
                        gdm->tty_dev->recv_func(gdm->tty_dev->priv_dev,
                                                gdm_tty_recv_complete);
@@ -140,7 +143,7 @@ static void gdm_tty_send_complete(void *arg)
 {
        struct gdm *gdm = arg;
 
-       if (!GDM_TTY_READY(gdm))
+       if (!gdm_tty_ready(gdm))
                return;
 
        tty_port_tty_wakeup(&gdm->port);
@@ -154,7 +157,7 @@ static int gdm_tty_write(struct tty_struct *tty, const unsigned char *buf,
        int sent_len = 0;
        int sending_len = 0;
 
-       if (!GDM_TTY_READY(gdm))
+       if (!gdm_tty_ready(gdm))
                return -ENODEV;
 
        if (!len)
@@ -181,7 +184,7 @@ static unsigned int gdm_tty_write_room(struct tty_struct *tty)
 {
        struct gdm *gdm = tty->driver_data;
 
-       if (!GDM_TTY_READY(gdm))
+       if (!gdm_tty_ready(gdm))
                return 0;
 
        return WRITE_SIZE;