Code cleanup: JobAction::build() uses Json::Value::isMember() instead of getMemberNames()

Change-Id: I8b31aff20ab99f880984001e511496f907a0a3c9
Signed-off-by: Mu-Woong Lee <muwoong.lee@samsung.com>

diff --git a/src/shared/JobAction.cpp b/src/shared/JobAction.cpp
index 7e13f75..e6c3978 100644 (file)
--- a/src/shared/JobAction.cpp
+++ b/src/shared/JobAction.cpp
@@ -70,19 +70,16 @@ JobAction::~JobAction()
 
 JobAction* JobAction::build(Json::Value& jsonNode)
 {
-       Json::Value::Members members = jsonNode.getMemberNames();
-       IF_FAIL_RETURN(!members.empty(), NULL);
+       if (jsonNode.isMember(KEY_APP_CTRL))
+               return new JobAppControl(jsonNode[KEY_APP_CTRL]);
 
-       if (members[0] == KEY_DBUS) {
+       if (jsonNode.isMember(KEY_DBUS))
                return new JobDBusCall(jsonNode[KEY_DBUS]);
 
-       } else if (members[0] == KEY_APP_CTRL) {
-               return new JobAppControl(jsonNode[KEY_APP_CTRL]);
-
-       } else if (members[0] == KEY_NOTI) {
+       if (jsonNode.isMember(KEY_NOTI))
                return new JobNotification(jsonNode[KEY_NOTI]);
-       }
 
+       _W("No action");
        return NULL;
 }